Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Activities feature branch #25450

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

mna
Copy link
Member

@mna mna commented Jan 15, 2025

Feature branch for #22866

For #23912

Add the ability to cancel upcoming activities in the UI. This adds that
functionality but also changes the design of the activities used on the
past and upcoming feeds. This PR includes:

**new UI for activities on past and upcoming activity feeds **


![image](https://github.com/user-attachments/assets/f970a4fe-a04b-49cb-8b76-bbaf1f8dff02)

**ability to cancel an upcoming activity**


![image](https://github.com/user-attachments/assets/00107135-6a62-40d6-8c8d-9f16b7ae049a)

**changes to the global activities to use the new activity behaviour and
styles:**


![image](https://github.com/user-attachments/assets/d5bbd7e4-9879-45d0-b12c-188067c4253f)


> NOTE: there will need to be more work done to integrate with the API
when this is ready. That will be done in another PR.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [ ] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
relates to #23912

This renders the fleet avatar if the activity is fleet initiated 


![image](https://github.com/user-attachments/assets/cb28f6e8-e5bd-4dad-8c68-bdce2ee6349e)

- [ ] Added/updated automated tests
- [ ] Manual QA for all new/changed functionality
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (298ad67) to head (594d358).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25450      +/-   ##
==========================================
- Coverage   63.60%   63.58%   -0.03%     
==========================================
  Files        1626     1625       -1     
  Lines      155542   154679     -863     
  Branches     3994     4018      +24     
==========================================
- Hits        98939    98356     -583     
+ Misses      48804    48541     -263     
+ Partials     7799     7782      -17     
Flag Coverage Δ
frontend 53.35% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants